fix!: Make Tabs correctly handle a single Tab Button #1775
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VincentSmedinga
changed the title
…/DES-1094-tabs-list-with-one-child
github-actions
bot
temporarily deployed
to
demo-DES-1094-tabs-list-with-one-child
|
Tested it again in the Tabs Story and in the existing Tabs in Amopis in Prototypes. This PR seems to fix the bug. |
VincentSmedinga
approved these changes
Dec 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the pull request
A fix for issue #1774 that Tabs List gives an breaking error when there is only one, non-iterable element in the Tabs List.
What
A Tabs List does not always expect multiple React Node's.
Why
Tabs (List) should be able to handle a single Tab button.
How
Remove the map method and just returning the value of
children.Checklist
Before submitting your pull request, please ensure you have done the following. Check each checkmark if you have done so or if it wasn't necessary:
Additional notes